build aarch64 with manylinux2_28 #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: "linux-arm-${{ matrix.python-version }}" | ||
| name: "linux-${{matrix.platform.arch}}-${{ matrix.python-version[1] }}" |
There was a problem hiding this comment.
Since the name is changed from ubuntu-latest-xxx to linux-x86_64-xxx, the named referred in the verify task should also be updated? Otherwise it cannot find the artifact: https://github.com/davidhewitt/connector-x/actions/runs/18595020541/job/53024260726#step:4:16
There was a problem hiding this comment.
Thanks, I simplified the verify jobs - new CI run at https://github.com/davidhewitt/connector-x/actions/runs/18651351271
|
Thank you @davidhewitt ! I have merged the PR and will release an alpha version using this new workflow. |
|
The new alpha version is release, feel free to try out: |
|
Super, thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
manylinux_2_28container to run the aarch64 build (on an arm runner natively).cc @pangjunrong you noted that this had problems building with the
manylinux_2_28container. From the test run on my fork, this worked fine: https://github.com/davidhewitt/connector-x/actions/runs/18595020541Maybe I missed something?
This allows the aarch64 build to match the x86_64 one of glibc 2.28.