Add phase awareness to slider entities #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits the single phase entities to the maximum power rating for the single phase This change might result in int min/max outliers due to the min/max of the slider shifting and possibly being out of bounds before the shift.
sfstar
force-pushed
the
feature/enhance_three_phase_compatibility
branch
from
9942e37 to
ae64cbb
Compare
|
This is an potential breaking change since the sliders kan reset to an out-of-bounds value -32768 or 32768 if the slider has a value that is below or above the new min/max limits. |
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the single phase entities to the maximum power rating for the single phase This change might result in int min/max outliers due to the min/max of the slider shifting and possibly being out of bounds before the shift.