Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map and tweak responsiveness of its container #88

Merged
merged 9 commits into from
Nov 24, 2024

Conversation

nickvisut
Copy link
Collaborator

@nickvisut nickvisut commented Nov 20, 2024

Description

Add Mapbox map to main page and . Also adds a handful of example soft stories as Mapbox markers.

Closes #72

Type of changes

  • Bugfix
  • Chore
  • New Feature

Testing

  • I added automated tests
  • I think tests are unnecessary

How to test

Run app, open index page and observe that map of SF is showing. Compare to Figma design. Attempt to pan/zoom with mouse and touch across diff devices and/or browser view port sizes.

Please also refer to requirements in #72, also linked in the right panel under "Development".

app/components/map.tsx Outdated Show resolved Hide resolved
app/components/map.tsx Outdated Show resolved Hide resolved
app/components/map.tsx Outdated Show resolved Hide resolved
app/components/map.tsx Outdated Show resolved Hide resolved
app/components/map.tsx Outdated Show resolved Hide resolved
app/components/map.tsx Outdated Show resolved Hide resolved
@nickvisut nickvisut marked this pull request as ready for review November 23, 2024 22:17
@nickvisut
Copy link
Collaborator Author

@mantuok OK I polished this up, added some missing things based on your feedback, and pulled it out of draft. FYI I rebased on master, so you may need to clear out this branch locally to get the new version.

Furthermore, note that I adopted your naming convention for the mapbox token, so you can get rid of the other one locally if you still see it there.

@nickvisut
Copy link
Collaborator Author

@mantuok OK I polished this up, added some missing things based on your feedback, and pulled it out of draft. FYI I rebased on master, so you may need to clear out this branch locally to get the new version.

Furthermore, note that I adopted your naming convention for the mapbox token, so you can get rid of the other one locally if you still see it there.

FYI I just did the force push that rebases on master.

@nickvisut nickvisut changed the title add map and tweak responsive height of its container add map and tweak responsiveness of its container Nov 23, 2024
@nickvisut nickvisut linked an issue Nov 23, 2024 that may be closed by this pull request
15 tasks
.env.example Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
app/page.tsx Show resolved Hide resolved
app/page.tsx Show resolved Hide resolved
app/page.tsx Show resolved Hide resolved
app/page.tsx Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@mantuok mantuok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works and good to go!

@nickvisut nickvisut merged commit d5fbee8 into master Nov 24, 2024
3 checks passed
@nickvisut nickvisut deleted the feature/add-mapbox-gl branch November 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Mapbox Map into Web App
4 participants