Skip to content

Conversation

@yougotwill
Copy link
Contributor

@yougotwill yougotwill commented Apr 2, 2025

  • Replaced the dirty_sed command with naughty-patch which uses git diff patches to resolve oxen-logging issues when building on windows.
  • Updated the README instructions for compiling a non-electron build to include running yarn naughty-patch and yarn update_version before yarn install as they are prerequisites.
  • Changed the virtual environment creation command from virtualenv to python -m venv. We don't enforce the python version at this time so we don't need virtualenv and can rely on python's native module.
  • Updated the libsession-util submodule commit to the latest version to fix build issues with cmake.

@yougotwill yougotwill marked this pull request as ready for review April 2, 2025 03:46
@yougotwill yougotwill requested a review from Bilb April 2, 2025 03:46
@yougotwill yougotwill marked this pull request as draft April 2, 2025 03:49
@yougotwill yougotwill marked this pull request as ready for review April 2, 2025 03:56
@Bilb Bilb merged commit d1703f8 into session-foundation:main Apr 2, 2025
3 checks passed
@yougotwill yougotwill deleted the fix/no-ref/zstd_cmake_min branch April 2, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants