Mark border-color and border-radius as repaint
#253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of d10ddec Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
* Define main version number at the workspace level This is the version number that most of the Stylo packages follow * Define in-repo dependencies at the workspace level * Add back newline at end of workspace Cargo.toml Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
This patch does various things: - Unifies the definitions and implementations of `ImportSheet` among Gecko and Servo. In particular, Servo gains `ImportSheet::Pending`. - Removes unsound `StylesheetContents::from_data()`, which we were keeping as a diff from upstream. - Removes `Stylesheet::update_from_bytes`. It was only used by Servo, which will no longer need it. Signed-off-by: Oriol Brufau <[email protected]>
…ter (servo#251) It was previously taking a `MediaList` parameter, and then wrap it in a locked arc. This was suboptimal for callers that already have an `Arc<Locked<MediaList>>`. Signed-off-by: Oriol Brufau <[email protected]>
Collaborator
|
Sounds fine, but please run tests in Servo |
It's no longer needed. Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
border-damage
branch
from
ae1fd7a to
8daa45b
Compare
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
border-damage
branch
from
8daa45b to
e04e74a
Compare
Loirooriol
reviewed
Oct 14, 2025
| logical_group="border-color", | ||
| allow_quirks="No" if is_logical else "Yes", | ||
| ignored_when_colors_disabled=True, | ||
| servo_restyle_damage="repaint", |
Collaborator
There was a problem hiding this comment.
For collapsed table borders, the color is resolved during layout. So I don't think this will work
Collaborator
Author
There was a problem hiding this comment.
Hmm... we should probably change that (presumably by resolving the source of the color in layout but not the actual color) because changing border-color of e.g. a button on :hover or :active is pretty common and we really don't want to be re-running layout for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servo PR: servo/servo#39864