webxr: create glwindow with Rc window and without rendering context #34813
Conversation
Signed-off-by: Wu Yu Wei <[email protected]>
Signed-off-by: Wu Yu Wei <[email protected]>
|
@jdm Hmm okay I noticed I should hide the window at first. I was testing on wayland and it won't show the window if it's empty, and I thought it worked. update: Nvm, my refactor to deprecate winit method also caused the guard fails already. Now, I can test some samples on Windows actually with these changes. |
Signed-off-by: Wu Yuwei <[email protected]>
Now glwindow will create a hidden window. It's better to not use it unless we really want to use this port. Signed-off-by: Wu Yu Wei <[email protected]>
|
Here's how it works on wayland to prove the connection is created from provided display handle (since Window's connetion is an empty type)
And Window's sample to confirm the window is hidden by default and will only be visible until the session is requested:
|
Signed-off-by: Wu Yu Wei <[email protected]>
…34813) (linux windows) {"fail_fast": false, "matrix": [{"name": "Linux", "workflow": "linux", "wpt_layout": "none", "profile": "release", "unit_tests": true, "bencher": false, "wpt_args": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "bencher": false, "wpt_args": ""}]}
…34813) (linux) {"fail_fast": false, "matrix": [{"name": "Linux", "workflow": "linux", "wpt_layout": "none", "profile": "release", "unit_tests": true, "bencher": false, "wpt_args": ""}]}
…34813) (linux windows) {"fail_fast": false, "matrix": [{"name": "Linux", "workflow": "linux", "wpt_layout": "none", "profile": "release", "unit_tests": true, "bencher": false, "wpt_args": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "bencher": false, "wpt_args": ""}]}
Companion PR of servo/webxr#257
Part of #34522
This PR clarifies rendering context usage in Weber. WebXR's window creates its own Surfman context, so it doesn't really need to pass the rendering context's information. This should simplify the usage for rendering context.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors