Skip to content

Refactor v2: faster pop/reserve/retain_mut, modern Criterion benches, Miri-friendly tests + fmt in CI #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fereidani wants to merge 8 commits into
base: v2
Choose a base branch
from
Open

Refactor v2: faster pop/reserve/retain_mut, modern Criterion benches, Miri-friendly tests + fmt in CI #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c43fac
Refactor benchmarks to use Criterion and add retain_mut methods for V…
fereidani Dec 8, 2025
9f72ad4
Refactor use less elements when test is running on miri
fereidani Dec 8, 2025
295959a
Refactor retain_mut method for improved performance and clarity
fereidani Dec 8, 2025
6beb40d
Refactor reserve and reserve_exact methods for improved performance a…
fereidani Dec 8, 2025
e4ee090
Refactor pop method for improved performance
fereidani Dec 8, 2025
7882aec
Cargo fmt
fereidani Dec 8, 2025
5ac72ef
Add Cargo fmt step to CI workflow for code formatting checks
fereidani Dec 8, 2025
0f2fd38
Optimize retain_mut method by adding early return for empty vectors
fereidani Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ jobs:
- name: Cargo test w/ malloc_size_of
run: cargo test --verbose --features malloc_size_of

- name: Cargo fmt
run: cargo --all -- --check

- name: Cargo check w/o default features
if: matrix.toolchain == 'nightly'
run: cargo check --verbose --no-default-features
Expand Down Expand Up @@ -92,4 +95,3 @@ jobs:
- name: Mark the job as unsuccessful
run: exit 1
if: "!success()"

6 changes: 6 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ malloc_size_of = { version = "0.1.1", optional = true, default-features = false

[dev-dependencies]
bincode = "1.0.1"
criterion = "0.8"

[package.metadata.docs.rs]
all-features = true
rustdoc-args = ["--cfg", "docsrs"]

[[bench]]
name = "bench"
path = "benches/bench.rs"
harness = false
Loading