Unified Builds of jsapi and jsglue #553
Conversation
We should pin LLVM to 19 in CI then (but only for aarch64), this is not used in servo so it should not be a problem there. |
|
This makes everything much clear and consistent! Before landing this we should make companion PR to servo to be sure we don't brake anything there. |
Unified cc and bindgen Flags Reorganized Buildscript Signed-off-by: Redfire <[email protected]>
Redfire75369
force-pushed
the
build/unified
branch
3 times, most recently
from
021bda7 to
84e15af
Compare
Signed-off-by: Redfire <[email protected]>
Redfire75369
force-pushed
the
build/unified
branch
from
84e15af to
622ccfa
Compare
|
I think this will need mozjs-sys bump. |
Signed-off-by: Redfire <[email protected]>
Redfire75369
force-pushed
the
build/unified
branch
from
7436008 to
1ba688a
Compare
|
Should it be a minor or patch bump? |
just the EDIT: |
Signed-off-by: Redfire <[email protected]>
Redfire75369
force-pushed
the
build/unified
branch
from
d1c039a to
98e210d
Compare
Unified flags, as well as the usage of
ccandbindgenforjsapiandjsglue.Reorganised the
build.rsprimarily for the unification, but there are some changes in ordering and module organisation.I'm not 100% sure on the ordering, so if you would like, that can be changed as well.
Resolves #435 through the removal of
-x c++and addition of--driver-mode=clon windows from the invocations ofbindgen. Replaces #437.Note the failures in
aarch64-pc-windows-msvcare due to an error in llvm 18 llvm/llvm-project#93235 (see rust-lang/rust-bindgen#2842 also). LLVM 18.1.8 is installed on github actions runners for windows-2022. I have tested that LLVM 19 works correctly on spiderfire.