Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows optionally disabling JIT by removing the feature. This is necessary on some variants of OpenHarmony, when JIT is forbidden by a system policy.
My idea is that on the servo side, I would disable
default-features
for mozjs whentarget_env = "ohos"
, since the dependency on mozjs is in the script crate. One could then add a direct dependency inservoshell
on mozjs (again only for OpenHarmony), so that we can expose a top-level featurejs-jit
to the user running./mach
, since they are the only one that know if their distribution of openharmony allows jit or not.Edit:
on the servo side I previously tried setting all the following
prefs
to false, which still caused JIT related crashes: