Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store xml namespace attributes for later serialization #586

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

devongovett
Copy link
Contributor

Fixes #569

This is @jdm's xmlns-attrs branch posted in #569, plus an update to xml5lib-tests by @Ygg01 (#569 (comment))

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's push the button! Sorry for the dropping the ball on this.

@jdm jdm added this pull request to the merge queue Apr 4, 2025
Merged via the queue into servo:main with commit 1d8748b Apr 4, 2025
6 checks passed
jdm added a commit that referenced this pull request Apr 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2025
* Revert "Bump rcdom/xml5lib-tests from `9a7ca89` to `a6d626e` (#589)"

This reverts commit e9b044c.

* Revert "Store xml namespace attributes for later serialization (#586)"

This reverts commit 1d8748b.

* Publish xml5ever 0.22.1.

Signed-off-by: Josh Matthews <[email protected]>

---------

Signed-off-by: Josh Matthews <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xmlns-prefixed attribute on root element is lost
2 participants