Merge pull request #75 from khhirani/fix-spec-validation-mismatch

fix: Modify Spec to make Weight and Service fields required
servicemeshinterface · Jun 26, 2020 · 7cd7340 · 7cd7340
2 parents 241f8c2 + 5b22aa4
commit 7cd7340
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/apis/split/v1alpha2/traffic_split.go b/pkg/apis/split/v1alpha2/traffic_split.go
@@ -33,8 +33,8 @@ type TrafficSplitSpec struct {
 
 // TrafficSplitBackend defines a backend
 type TrafficSplitBackend struct {
-	Service string `json:"service,omitempty"`
-	Weight  int    `json:"weight,omitempty"`
+	Service string `json:"service"`
+	Weight  int    `json:"weight"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

diff --git a/pkg/apis/split/v1alpha3/traffic_split.go b/pkg/apis/split/v1alpha3/traffic_split.go
@@ -38,8 +38,8 @@ type TrafficSplitSpec struct {
 
 // TrafficSplitBackend defines a backend
 type TrafficSplitBackend struct {
-	Service string `json:"service,omitempty"`
-	Weight  int    `json:"weight,omitempty"`
+	Service string `json:"service"`
+	Weight  int    `json:"weight"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object