Bump supported version to Debian 13 #21
Conversation
WalkthroughAdds Debian 13 (trixie) support: documented in README, detected in sok-find-os.sh, and handled with a new Debian 13 branch in squid3-install.sh mirroring Debian 12 behavior. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant I as squid3-install.sh
participant D as sok-find-os.sh
participant A as apt/iptables/systemd
participant C as serverok.conf source
U->>I: Run installer
I->>D: Detect OS
D-->>I: "debian13" (for trixie)
alt debian13
I->>A: apt update && install apache2-utils,squid
I->>A: create /etc/squid/passwd
I->>C: download /etc/squid/conf.d/serverok.conf
I->>A: iptables -A INPUT -p tcp --dport 3128 -j ACCEPT (if available)
I->>A: systemctl enable --now squid
else other supported OS
I->>A: Execute respective install flow
else unknown OS
I-->>U: ERROR
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
sok-find-os.sh (1)
35-36: Debian 13 (trixie) detection added — consider making the match case-insensitive and slightly more robust.The new branch works as-is. As a minor hardening, matching case-insensitively avoids surprises, and aligning to
grep -qimproves readability.Apply this minimal diff:
-elif cat /etc/os-release | grep PRETTY_NAME | grep "trixie" > /dev/null; then +elif cat /etc/os-release | grep PRETTY_NAME | grep -qi "trixie"; then echo "debian13"Optional broader refactor (for later):
source /etc/os-releaseonce and switch onVERSION_CODENAME/VERSION_IDto avoid multiple pipes and repeated reads.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README.md(1 hunks)sok-find-os.sh(1 hunks)squid3-install.sh(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
squid3-install.sh (1)
fabric/fabfile.py (1)
squid(9-19)
🪛 LanguageTool
README.md
[grammar] ~8-~8: There might be a mistake here.
Context: ...04, 18.04 * Debian 13, 12, 11, 10, 9, 8 * CentOS 8 * CentOS Steam 9, 8 * AlmaLinux...
(QB_NEW_EN)
🔇 Additional comments (2)
README.md (1)
8-8: Debian 13 addition looks good.The supported-OS list now reflects Debian 13. No functional impact here.
squid3-install.sh (1)
182-193: Ensure correct OS comment and create conf.d directoryConfirmed that
debian12.confexists upstream (HTTP 200) anddebian13.confdoes not (HTTP 404), so continue referencingdebian12.conf. Update the comment to Debian 13 (trixie) and addmkdir -pto guard against missingconf.d.• File: squid3-install.sh, lines 182–193
elif [ $SOK_OS == "debian13" ]; then - # OS = Debian GNU/Linux 12 (bookworm) + # OS = Debian GNU/Linux 13 (trixie) /bin/rm -rf /etc/squid /usr/bin/apt update > /dev/null 2>&1 /usr/bin/apt -y install apache2-utils squid > /dev/null 2>&1 touch /etc/squid/passwd + /bin/mkdir -p /etc/squid/conf.d /usr/bin/wget -q --no-check-certificate \ -O /etc/squid/conf.d/serverok.conf \ https://raw.githubusercontent.com/serverok/squid-proxy-installer/master/conf/debian12.conf if [ -f /sbin/iptables ]; then /sbin/iptables -I INPUT -p tcp --dport 3128 -j ACCEPT fi systemctl enable squid systemctl restart squid
1 participant
Summary by CodeRabbit