-
Notifications
You must be signed in to change notification settings - Fork 166
Adding MCP call (via HTTP) #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have a few questions if you don't mind.
Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
@amin-nikanjam Could you please sign-off your commits? |
Done! |
@amin-nikanjam DCO is still not passing. Please follow the steps enumerated in the following link to ensure it checks: https://github.com/serverlessworkflow/specification/pull/1116/checks?check_run_id=49885563716 |
Signed-off-by: amin-nikanjam <[email protected]>
@amin-nikanjam Why are we not supporting stdio transport, too? I feel it is but trivial to add support for it, isn't it? |
Right, we are not supporting the stdio now. While in MCP spec it is clarified that "Clients SHOULD support stdio whenever possible", we can add it. |
@amin-nikanjam apart from adding |
Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]> Signed-off-by: amin-nikanjam <[email protected]>
Adding the description to examples. Signed-off-by: amin-nikanjam <[email protected]>
Testing a fix Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Rephrasing the description. Co-authored-by: Ricardo Zanini <[email protected]>
@amin-nikanjam can you please squash and sign your commit? |
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
Additional information: