Skip to content

Conversation

amin-nikanjam
Copy link

@amin-nikanjam amin-nikanjam commented Sep 5, 2025

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

Additional information:

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few questions if you don't mind.

Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
@cdavernas
Copy link
Member

@amin-nikanjam Could you please sign-off your commits?

@amin-nikanjam
Copy link
Author

@amin-nikanjam Could you please sign-off your commits?

Done!

@cdavernas
Copy link
Member

@amin-nikanjam DCO is still not passing. Please follow the steps enumerated in the following link to ensure it checks: https://github.com/serverlessworkflow/specification/pull/1116/checks?check_run_id=49885563716

Signed-off-by: amin-nikanjam <[email protected]>
@cdavernas
Copy link
Member

@amin-nikanjam Why are we not supporting stdio transport, too? I feel it is but trivial to add support for it, isn't it?

@amin-nikanjam
Copy link
Author

amin-nikanjam commented Sep 9, 2025

@amin-nikanjam Why are we not supporting stdio transport, too? I feel it is but trivial to add support for it, isn't it?

Right, we are not supporting the stdio now. While in MCP spec it is clarified that "Clients SHOULD support stdio whenever possible", we can add it.

@ricardozanini
Copy link
Member

@amin-nikanjam apart from adding stido, can you please check the CI?

Signed-off-by: amin-nikanjam <[email protected]>
amin-nikanjam and others added 6 commits September 9, 2025 15:22
Signed-off-by: amin-nikanjam <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Adding the description to examples.

Signed-off-by: amin-nikanjam <[email protected]>
Testing a fix

Signed-off-by: amin-nikanjam <[email protected]>
Signed-off-by: amin-nikanjam <[email protected]>
Rephrasing the description.

Co-authored-by: Ricardo Zanini <[email protected]>
@ricardozanini
Copy link
Member

@amin-nikanjam can you please squash and sign your commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants