Skip to content

Various 🐛-fixes - #8

Merged
serkor1 merged 12 commits into
develfrom
bugfix
Oct 30, 2025
Merged

Various 🐛-fixes #8
serkor1 merged 12 commits into
develfrom
bugfix

Conversation

@serkor1

@serkor1 serkor1 commented Oct 29, 2025

Copy link
Copy Markdown
Owner

📚 What?

This PR is focused on meticulously going through the source code to check for bugs. One critical bug were found:

Acceleration Bands

  • The acceleration bands were using the incorrect input columns, and were returning columns in the wrong order (similar to that of Bollinger Bands bug, somewhere).

Minor bugs

  • Mispelled functions names

Otherwise no bugs were found on the core implementation.

@serkor1 serkor1 added the bug Something isn't working label Oct 29, 2025
@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.27749% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.03%. Comparing base (879d9ee) to head (9d043d7).
⚠️ Report is 13 commits behind head on devel.

Files with missing lines Patch % Lines
src/container.h 57.14% 12 Missing ⚠️
src/ta_CDL2CROWS.c 0.00% 1 Missing ⚠️
src/ta_CDL3BLACKCROWS.c 0.00% 1 Missing ⚠️
src/ta_CDL3INSIDE.c 50.00% 1 Missing ⚠️
src/ta_CDL3LINESTRIKE.c 0.00% 1 Missing ⚠️
src/ta_CDL3OUTSIDE.c 0.00% 1 Missing ⚠️
src/ta_CDL3STARSINSOUTH.c 0.00% 1 Missing ⚠️
src/ta_CDL3WHITESOLDIERS.c 0.00% 1 Missing ⚠️
src/ta_CDLABANDONEDBABY.c 0.00% 1 Missing ⚠️
src/ta_CDLADVANCEBLOCK.c 0.00% 1 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##            devel       #8      +/-   ##
==========================================
+ Coverage   92.29%   94.03%   +1.73%     
==========================================
  Files         239      240       +1     
  Lines       11310    11011     -299     
==========================================
- Hits        10439    10354      -85     
+ Misses        871      657     -214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* The acceleration bands uses high, low and close.
  This bug is critical as similar bugs are probably present
  in the remaining functions

* The column names in the returned matrix were reversed, similar
  to that of the bollinger bands.
* The goal of header-file is to abstract parts of the
  core implementation to reduce the likelihood of bugs.
* The main point of the update is to ensure there are
  no other bugs.
* The main point of the update is to ensure there are
  no other bugs.
* ADXR were mispelled, otherwise no real bugs found. All signatures have been
  checked, and double checked.
* No bugs or errors found.
* Updated LLVM formatting. The project should now be less dependent on clang-format guards.
* init.c has changed (No clue why...)
@serkor1
serkor1 merged commit 14fd3a0 into devel Oct 30, 2025
12 of 13 checks passed
@serkor1
serkor1 deleted the bugfix branch October 30, 2025 21:10
serkor1 added a commit that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant