🚀 Candlestick Settings and Documentation - #7
Merged
Merged
Conversation
* When initializing TA-Lib it would reset the candlestick settings. This has been removed as all settings are handled by reset_candle_setting() * set_candle_setting() controls all candlestick setting and throws a warning if its not possible.
* The candles are now reset on unload and detach instead of load.
* Related to d0d0e30. The core idea is to set the settings via options() to avoid exporting more functions on the user-side. At the moment there are over 100 unique functions, and its starting to get cluttered. Until someone specifically finds a proper use-case for adding a specific function this is the way to go.
* The templates now supports the full documentation of the
options and sets the options within each pattern call.
NOTE: This is a rather crude implementation because each function is calling
the setter everytime, even if it has not been changed. Its HIGHLY inefficient,
but I am running out of ideas here. See the discussion here: cc1ca7e
* Documentation should really be handled via GHA, the committed number
of files is getting out of hand really.
SOON(TM)
* Honestly this change took me by surprise, I see not difference in the charts. So its anyones guess; I have nothing to add here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #7 +/- ##
==========================================
+ Coverage 92.23% 92.29% +0.06%
==========================================
Files 239 239
Lines 11156 11310 +154
==========================================
+ Hits 10290 10439 +149
- Misses 866 871 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serkor1
marked this pull request as ready for review
October 29, 2025 21:05
* The types were mismatched.
* The candles were reset *after* TA-Lib is shutdown, which should be logically impossible. There were no errors in the unit-tests, but just in case.
* The vignette is a draft, and demonstrates the basic usage and interpretation of the candlesticks and related options.
* The vignette is now more detailed, and contains more examples.
serkor1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
This PR implements candlestick settings and expands the documentation of candlestick pattern recognition functions.