Skip to content

🚀 Include all patterns - #3

Merged
serkor1 merged 7 commits into
develfrom
expand_pattern
Oct 18, 2025
Merged

🚀 Include all patterns#3
serkor1 merged 7 commits into
develfrom
expand_pattern

Conversation

@serkor1

@serkor1 serkor1 commented Oct 18, 2025

Copy link
Copy Markdown
Owner

Note

As the R package is still in the development phase these PRs are mostly for internal tracking, if you are interested in the full range of changes please see the commit history.

📚 What?

This PR implements all candlestick patterns. It will, in any case, require some reworking as some of the functionality in charting patterns are not available before #2 is merged.

* Updated api.h and init.c accordingly
* The documentation is updated separately.
* The entire family of candlestick patterns have been updated to accomodate
  the new patterns.
@serkor1 serkor1 added the enhancement New feature or request label Oct 18, 2025
@codecov

codecov Bot commented Oct 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2912 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.25%. Comparing base (9c0c965) to head (ec135ee).
⚠️ Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
R/ta_CDLHARAMICROSS.R 0.00% 69 Missing ⚠️
R/ta_CDLHIGHWAVE.R 0.00% 69 Missing ⚠️
R/ta_CDLHIKKAKE.R 0.00% 69 Missing ⚠️
R/ta_CDLHIKKAKEMOD.R 0.00% 69 Missing ⚠️
R/ta_CDLHOMINGPIGEON.R 0.00% 69 Missing ⚠️
R/ta_CDLIDENTICAL3CROWS.R.R 0.00% 69 Missing ⚠️
R/ta_CDLINNECK.R 0.00% 69 Missing ⚠️
R/ta_CDLINVERTEDHAMMER.R 0.00% 69 Missing ⚠️
R/ta_CDLKICKING.R 0.00% 69 Missing ⚠️
R/ta_CDLKICKINGBABYLENGTH.R 0.00% 69 Missing ⚠️
... and 58 more
Additional details and impacted files
@@             Coverage Diff             @@
##            devel       #3       +/-   ##
===========================================
- Coverage   81.80%   58.25%   -23.55%     
===========================================
  Files         130      198       +68     
  Lines        7205    10117     +2912     
===========================================
  Hits         5894     5894               
- Misses       1311     4223     +2912     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Updated api.h and init.c accordingly
* The documentation is updated separately.
* The entire family of candlestick patterns have been updated to accomodate
  the new patterns.
@serkor1
serkor1 merged commit 2f63d72 into devel Oct 18, 2025
11 of 13 checks passed
@serkor1
serkor1 deleted the expand_pattern branch October 18, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant