Skip to content

windows overlapped io #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erkki-silvola
Copy link

No description provided.

@RossSmyth
Copy link
Contributor

RossSmyth commented May 20, 2025

This PR has not comments anywhere, no explanation/motivation, and doesn't seem very well planned. I would prefer the other PR over this one. Thanks though.

@sirhcel
Copy link
Contributor

sirhcel commented May 20, 2025

There is also #55 for the same topic.

@erkki-silvola
Copy link
Author

erkki-silvola commented May 22, 2025

There is also #55 for the same topic.

Yes, did look into to that originally. This pr solves the 0 timeout case, which is actually 0 compared to actually waiting for the event object where typical deviation is 4-20ms (when timeout > 0 there is is race between event object and timeout signal which is fine, though I guess if we want to rely on event object mostly then it could be so that if timeout > 0 then INFINITE is passed etc.), also somewhat cosmetic things related to handling event object(s) how it is normally done. My personal motivation would be to add later on cancellable rx event or eq. for streaming use case.

@erkki-silvola
Copy link
Author

After some thinking, I guess the most sense would make to disable the timeouts with setcommtimeouts, and only rely on wait timeout. Though one caveat remains if someone sets the timeout without setting the internal timeout, in that case only problem would be if internal timeout is lower than the set comm timeout one, then the timeout would be less than expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants