-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented junit 5 batching #3569
Conversation
Sorry, just realised I wasn't against latest HEAD - resubmitting in a moment |
serenity-junit5/pom.xml
Outdated
<dependency> | ||
<groupId>org.junit</groupId> | ||
<artifactId>junit-bom</artifactId> | ||
<version>${junit5.version}</version> | ||
<type>pom</type> | ||
<scope>import</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is needed since it is available in the ParentPom to avoid to define junit5 artifacts version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right @DanielFran - I removed that and all maven targets still ran okay 👍 - repushed and also added in some missing files that mysteriously were missing on last push 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is needed since it is available in the ParentPom to avoid to define junit5 artifacts version?
- Includes fixed cucumber tag expressions dependency
@nbarrett I need to roll this change back as the new dependency between serenity-cucumber and serenity-junit5 causes issues in existing projects. The serenity-junit5 and serenity-cucumber modules need to be independent of each other. |
Note that this is a resubmission of #3568 with a fix to the version of cucumber tag expressions.
This PR utilises the suite slicing that was originally implemented in serenity cucumber and now implements it with new
CucumberBatchTestEngine
which is an implementation ofHierarchicalTestEngine<CucumberEngineExecutionContext>
.Example runner class is shown below:
CucumberBatchTestEngine
depends on objects that were originally in thecucumber-serenity
module, but as part of this PR, these were moved out of that module into theserenity-junit5
module as it's not possible forserenity-junit5
to depend oncucumber-serenity
, given that there is an existing dependency the other way. So this was done to avoid a circular dependency. This moving of concerns may not be approved by @wakaleo - so I'll let him review and decide. Sorry, I didn't have too much time to work on this as I have work commitments!