Updated Readme for buffalo_l #1449
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added buffalo_l
|
Will create an issue if needed and also may be we may need to change portfolio image. |
corrected wrong importing.
serengil
reviewed
Mar 2, 2025
recorrecting modelling.py
serengil
reviewed
Mar 2, 2025
README.md
Outdated
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| <p align="center"><img src="https://raw.githubusercontent.com/serengil/deepface/master/icon/deepface-icon-labeled.png" width="200" height="240"></p> | |||
|
|
|||
| DeepFace is a lightweight [face recognition](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/) and facial attribute analysis ([age](https://sefiks.com/2019/02/13/apparent-age-and-gender-prediction-in-keras/), [gender](https://sefiks.com/2019/02/13/apparent-age-and-gender-prediction-in-keras/), [emotion](https://sefiks.com/2018/01/01/facial-expression-recognition-with-keras/) and [race](https://sefiks.com/2019/11/11/race-and-ethnicity-prediction-in-keras/)) framework for python. It is a hybrid face recognition framework wrapping **state-of-the-art** models: [`VGG-Face`](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/), [`FaceNet`](https://sefiks.com/2018/09/03/face-recognition-with-facenet-in-keras/), [`OpenFace`](https://sefiks.com/2019/07/21/face-recognition-with-openface-in-keras/), [`DeepFace`](https://sefiks.com/2020/02/17/face-recognition-with-facebook-deepface-in-keras/), [`DeepID`](https://sefiks.com/2020/06/16/face-recognition-with-deepid-in-keras/), [`ArcFace`](https://sefiks.com/2020/12/14/deep-face-recognition-with-arcface-in-keras-and-python/), [`Dlib`](https://sefiks.com/2020/07/11/face-recognition-with-dlib-in-python/), `SFace` and `GhostFaceNet`. | |||
| DeepFace is a lightweight [face recognition](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/) and facial attribute analysis ([age](https://sefiks.com/2019/02/13/apparent-age-and-gender-prediction-in-keras/), [gender](https://sefiks.com/2019/02/13/apparent-age-and-gender-prediction-in-keras/), [emotion](https://sefiks.com/2018/01/01/facial-expression-recognition-with-keras/) and [race](https://sefiks.com/2019/11/11/race-and-ethnicity-prediction-in-keras/)) framework for python. It is a hybrid face recognition framework wrapping **state-of-the-art** models: [`VGG-Face`](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/), [`FaceNet`](https://sefiks.com/2018/09/03/face-recognition-with-facenet-in-keras/), [`OpenFace`](https://sefiks.com/2019/07/21/face-recognition-with-openface-in-keras/), [`DeepFace`](https://sefiks.com/2020/02/17/face-recognition-with-facebook-deepface-in-keras/), [`DeepID`](https://sefiks.com/2020/06/16/face-recognition-with-deepid-in-keras/), [`ArcFace`](https://sefiks.com/2020/12/14/deep-face-recognition-with-arcface-in-keras-and-python/), [`Dlib`](https://sefiks.com/2020/07/11/face-recognition-with-dlib-in-python/), [`Insightface's Buffalo_L`](https://github.com/deepinsight/insightface/tree/master/model_zoo), `SFace`, `GhostFaceNet`. | |||
There was a problem hiding this comment.
Please add Buffalo_L to the end, just after GhostFaceNet. Because, it is recently added. Also, don't give link to repo here.
We are giving reference to the original repos in the license section. You also missed it.
serengil
reviewed
Mar 2, 2025
README.md
Outdated
| @@ -121,7 +121,7 @@ Here, embedding is also [plotted](https://sefiks.com/2020/05/01/a-gentle-introdu | |||
|
|
|||
| **Face recognition models** - [`Demo`](https://youtu.be/eKOZawGR3y0) | |||
|
|
|||
| DeepFace is a **hybrid** face recognition package. It currently wraps many **state-of-the-art** face recognition models: [`VGG-Face`](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/) , [`FaceNet`](https://sefiks.com/2018/09/03/face-recognition-with-facenet-in-keras/), [`OpenFace`](https://sefiks.com/2019/07/21/face-recognition-with-openface-in-keras/), [`DeepFace`](https://sefiks.com/2020/02/17/face-recognition-with-facebook-deepface-in-keras/), [`DeepID`](https://sefiks.com/2020/06/16/face-recognition-with-deepid-in-keras/), [`ArcFace`](https://sefiks.com/2020/12/14/deep-face-recognition-with-arcface-in-keras-and-python/), [`Dlib`](https://sefiks.com/2020/07/11/face-recognition-with-dlib-in-python/), `SFace` and `GhostFaceNet`. The default configuration uses VGG-Face model. | |||
| DeepFace is a **hybrid** face recognition package. It currently wraps many **state-of-the-art** face recognition models: [`VGG-Face`](https://sefiks.com/2018/08/06/deep-face-recognition-with-keras/) , [`FaceNet`](https://sefiks.com/2018/09/03/face-recognition-with-facenet-in-keras/), [`OpenFace`](https://sefiks.com/2019/07/21/face-recognition-with-openface-in-keras/), [`DeepFace`](https://sefiks.com/2020/02/17/face-recognition-with-facebook-deepface-in-keras/), [`DeepID`](https://sefiks.com/2020/06/16/face-recognition-with-deepid-in-keras/), [`ArcFace`](https://sefiks.com/2020/12/14/deep-face-recognition-with-arcface-in-keras-and-python/), [`Dlib`](https://sefiks.com/2020/07/11/face-recognition-with-dlib-in-python/),[`Insightface's Buffalo_L`](https://github.com/deepinsight/insightface/tree/master/model_zoo), `SFace` and `GhostFaceNet`. The default configuration uses VGG-Face model. | |||
serengil
reviewed
Mar 2, 2025
README.md
Outdated
| @@ -134,9 +134,11 @@ models = [ | |||
| "ArcFace", | |||
| "Dlib", | |||
| "SFace", | |||
| "GhostFaceNet" | |||
| "GhostFaceNet", | |||
| "Buffalo_L" (InsightFace-based, requires additional dependencies; see Installation) | |||
There was a problem hiding this comment.
Just mention Buffalo_L, don't mention (InsightFace-based, requires additional dependencies; see Installation)
Similarly, Dlib is optional and we didn't mention anything.
serengil
reviewed
Mar 2, 2025
README.md
Outdated
| @@ -158,10 +160,13 @@ embedding_objs = DeepFace.represent( | |||
| ) | |||
| ``` | |||
|
|
|||
| **Note:** The `Buffalo_L` model uses InsightFace’s `webface_r50.onnx`. If automated download fails, manually download it from [here](https://drive.google.com/file/d/1N0GL-8ehw_bz2eZQWz2b0A5XBdXdxZhg/view?usp=sharing) and place it in `~/.deepface/weights/buffalo_l/`. | |||
There was a problem hiding this comment.
We don't need this description at all. Any weight file can be failed. Users know what to do in the exception message.
serengil
reviewed
Mar 2, 2025
README.md
Outdated
| @@ -202,6 +207,9 @@ dfs = DeepFace.find( | |||
| ) | |||
| ``` | |||
|
|
|||
| **Note:** The `Buffalo_L` model works best with cosine similarity. you can play around with the thresholds as it pleases you. | |||
There was a problem hiding this comment.
We shouldn't mention this at all.
added buffalo_l
serengil
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
haven't created one.
What has been done
Updated readme with buffalo_l and added notes regarding the model.
How to test