Skip to content

Make difference between source and config dbs clearer #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

acco
Copy link
Contributor

@acco acco commented May 21, 2025

Summary

  • drop tables from playground.yml
  • clarify difference between PG_* env vars and YAML DB config in docs

Testing

  • mix format --check-formatted (fails: missing Hex and network access)
  • MIX_ENV=prod mix compile --warnings-as-errors (fails: missing Hex and network access)
  • go test ./cli (fails: cannot download toolchain)
  • gofmt -s -l .
  • go vet ./... (fails: cannot download toolchain)
  • go build -o /dev/null ./... (fails: cannot download toolchain)
  • make spellcheck (fails: npm registry unreachable)
  • make check-links (fails: npm registry unreachable)
  • npm run format:check
  • npm run tsc

@acco acco added the codex label May 21, 2025 — with ChatGPT Connector
@acco acco force-pushed the codex/update-docs-for-sinks-table-configuration branch from 04ebcb0 to ecd7559 Compare May 27, 2025 17:11
@acco acco marked this pull request as ready for review May 27, 2025 17:11
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 27, 2025
@acco acco merged commit a955afe into main May 27, 2025
3 checks passed
@acco acco deleted the codex/update-docs-for-sinks-table-configuration branch May 27, 2025 17:11
@acco acco changed the title Fix outdated tables in playground config Make difference between source and config dbs clearer May 27, 2025
@dosubot dosubot bot added the documentation Improvements or additions to documentation label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codex documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant