Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --label option #59

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

added --label option #59

wants to merge 12 commits into from

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Mar 13, 2024

This PR will add --label option to add labels in wave build images

this information is used to validate labels
https://docs.docker.com/config/labels-custom-metadata/

Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan self-assigned this Mar 13, 2024
@munishchouhan
Copy link
Member Author

this pr depends upon seqeralabs/libseqera#18

Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Copy link
Contributor

@marcodelapierre marcodelapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see old comments, plus a new one - thank you Munish

app/src/main/java/io/seqera/wave/cli/App.java Outdated Show resolved Hide resolved
app/src/main/java/io/seqera/wave/cli/App.java Outdated Show resolved Hide resolved
app/src/main/java/io/seqera/wave/cli/App.java Outdated Show resolved Hide resolved
munishchouhan and others added 4 commits April 10, 2024 11:00
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
@marcodelapierre
Copy link
Contributor

CI requires merge and release on Libseqera side: seqeralabs/libseqera#18

@marcodelapierre
Copy link
Contributor

@munishchouhan , as per change suggested in Libseqera seqeralabs/libseqera#18, also in this PR I have adopted the model where ContainerConfig.labels is a List, not a Map, similar to env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants