Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changes default url to https://api.cloud.seqera.io #452

Merged
merged 4 commits into from
Sep 23, 2024
Merged

chore: changes default url to https://api.cloud.seqera.io #452

merged 4 commits into from
Sep 23, 2024

Conversation

swampie
Copy link
Member

@swampie swampie commented Sep 10, 2024

This PR changes the default api endpoint from the legacy api.tower.nf to the new api.cloud.seqera.io

No regression on testing

@swampie swampie force-pushed the task_451/move_to_new_api_endpoint branch from 714d2aa to 4918642 Compare September 10, 2024 07:07
@tcrespog tcrespog linked an issue Sep 10, 2024 that may be closed by this pull request
New Platform endpoint should be used in place of tower.nf #451
Closed
@robnewman
Copy link
Member

robnewman commented Sep 10, 2024 •
edited
Loading

@tcrespog Aren't there additional incorrect references to tower.nf in the file src/test/resources/runcmd/info/service-info.json such as the links to Docs, Community, Feedback, landingUrl, termsOfUseUrl, contentUrl, and analytics.url?

Docs URL should be: https://docs.seqera.io/platform
Community URL should be: https://community.seqera.io
Feedback URL should be: https://feedback.seqera.io

@tcrespog
Copy link
Contributor

Aren't there additional incorrect references to tower.nf in the file src/test/resources/runcmd/info/service-info.json

That is a test file, but OK: I've just updated the remaining references.

tcrespog
tcrespog approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@tcrespog tcrespog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works successfully.

@robnewman
Copy link
Member

@tcrespog I think this can probably be rebased and merged, no?

@pditommaso pditommaso merged commit 0c1ac90 into master Sep 23, 2024
7 checks passed
@pditommaso
Copy link
Contributor

Surprised this was not yet merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcrespog tcrespog tcrespog approved these changes

@pditommaso pditommaso pditommaso approved these changes

@JaimeSeqLabs JaimeSeqLabs Awaiting requested review from JaimeSeqLabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Platform endpoint should be used in place of tower.nf
4 participants
@swampie @robnewman @tcrespog @pditommaso