Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release note improvements #222

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

justinegeffen
Copy link
Contributor

@justinegeffen justinegeffen commented Sep 16, 2024

  • Collapsed 2023 release notes
  • Removed prefixes "Feature" "Added" "Improvement" etc in favor of descriptive sentences
  • Removed some entries that were extraneous or vague
  • Removed GH commits and ticket number references
  • Rewrote some entries for clarity
  • Made older sections expandable to save space (open to ideas for the summary instead of a double up on year)

@justinegeffen justinegeffen added the 1. Editor review Needs a language review label Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 72b5373
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/66e8a9ec555de8000844e241
😎 Deploy Preview https://deploy-preview-222--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@llewellyn-sl llewellyn-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapsing last year's notes is a nice touch!

I left some comments regarding the entry format changes you made here, since they differ from the format we defined in Confluence and they'll also create a delta between Cloud and Enterprise changelog formats. So we'd either need to update all Enterprise changelogs to the new format, or stick to the format we were using.

- Fix: Improve workflow launch screen look and feel
- Fix: Allow pipeline work directory to be changed during pipeline launch
- Fix: Handle special characters in prompt modal confirmation text regex
### 24.2.0 - 2 September 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _cycle for each Cloud release is like a patch or minor release identifier, making each release unique. It's better to keep this than to have all releases in the major cycle have the same heading.

### 24.2.0 - 13 August 2024

- Add global Nextflow configuration support in compute environments
- Improved flexibility for pipeline names in workspaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the format that we documented here, then we'll have to change the same for all versions of Enterprise. So this PR creates a disparity between the formats of Cloud and Enterprise changelogs.

Copy link
Contributor Author

@justinegeffen justinegeffen Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was editing the docs, I realized that adding those prefixes didn't apply to everything so it looked disjointed - and it's not easy to remember the order off-hand which means it makes updating the docs tiresome.

If we don't add those prefixes, we have to write more descriptive sentences to make the changelog notes more meaningful which I believe is a good approach. It also rolls into another change I'd like to implement which is to separate bugs, features, fixes into their own sections (that'll be the next PR).

I don't necessarily agree that we have to change the format for everything - it can be a change going forward. It might make more sense/be more viable in the next PR because it'll be a more obvious break from the previous format and be a clear delineation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to including the changes I have in mind for the next PR into this PR so we can see how it looks.

- Bump nf-launcher:24.04.3

### 24.1.x Cloud - May 2024
### 24.1.x - May 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.1.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Editor review Needs a language review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants