Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE-V8] Add new fields #33
[RELEASE-V8] Add new fields #33
Changes from 9 commits
72ab4d2
2663720
912ce7a
88e563a
2c92c0a
bc9dc41
a09f09a
9b48ac2
316dff7
ef8f641
99fb8af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addCookie
or justcookie
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As addExtraHttpHeader you can add cookies in addition to the ones in the configuration file if needed.
And if not use cookies only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can have a look about the doc where I explain that 😉 Let me know what you think
https://github.com/sensiolabs/GotenbergBundle/pull/33/files#diff-dbcb3d682e3e3080ba4b0f0195b7215457be7782b74898ccbefed9a74ba3be26R267
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
addCookies
could be namedaddCookie
since we only add one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the method if the user wants to add several to those already loaded from their configuration file.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is confusing. On other classes we have singulars on
add
methods. I don't see why this one needs to be different. But maybe I'm just missing something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about
addExtraHttpHeaders
when I created that one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know and I can rename it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we name them
addCookies
andaddExtraHttpHeaders
, they should accept a list. If we name them without a "s" (addCookie
andaddExtraHttpHeader
), they should accept a single value.PS: I don't have a strong opinion on choosing one of these two solutions