feat: add Webhook component integration #120
Conversation
Jean-Beru
force-pushed
the
add-webhook-component-integration
branch
8 times, most recently
from
9b8c0c4 to
c5809a8
Compare
Jean-Beru
force-pushed
the
add-webhook-component-integration
branch
from
c5809a8 to
8c8d531
Compare
| @@ -23,6 +23,7 @@ | |||
| service('sensiolabs_gotenberg.asset.base_dir_formatter'), | |||
| service('.sensiolabs_gotenberg.webhook_configuration_registry'), | |||
| service('request_stack'), | |||
| service('router')->nullOnInvalid(), | |||
There was a problem hiding this comment.
Still no desire to clean this file ? 👼
$services->set('.sensiolabs_gotenberg.builder')
->abstract()
->args([
service('sensiolabs_gotenberg.client'),
service('sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('router')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
;
$services->set('.sensiolabs_gotenberg.pdf_builder.markdown', MarkdownPdfBuilder::class)
->parent('.sensiolabs_gotenberb.builder')
->share(false)
->tag('sensiolabs_gotenberg.pdf_builder')
;
// ... Or... even better: introduce a BuilderFactory ?
There was a problem hiding this comment.
Still no desire to clean this file ? 👼
I want to clean this file. I did it in a PoC about refactoring builder: #118
Or... even better: introduce a BuilderFactory ?
I also planned to test that 😉
|
|
||
| return new SuccessGotenbergEvent( | ||
| $id, | ||
| $request->getContent(true), |
There was a problem hiding this comment.
Is messenger able to serialize a resource ?
There was a problem hiding this comment.
Good catch!
I'll make some tests. It coud depend on the transport used (ex: 512Mb fot RabbitMQ)
There was a problem hiding this comment.
hmmmm. That would mean that we might need to save the file beforehand ?
There was a problem hiding this comment.
I don't get how it works... the "resource" here is some form POST data, right ? So there is a limit in Symfony itself to receive the form data, no ?
| public function __construct( | ||
| string $id, | ||
| mixed $file, | ||
| private readonly string $filename, | ||
| private readonly string $contentType, | ||
| private readonly int $contentLength, | ||
| ) { | ||
| $payload['file'] = $file; | ||
|
|
||
| parent::__construct(self::SUCCESS, $id, $payload); | ||
| } |
There was a problem hiding this comment.
Not sure i would create array like this :|
There was a problem hiding this comment.
Wow. I missed that one 😄
Besides, is it still relevant to add the file in $payload instead of adding an other private property?
Co-authored-by: Simon André <[email protected]>
Co-authored-by: Simon André <[email protected]>
Co-authored-by: Simon André <[email protected]>
| throw new MissingRequiredFieldException('->webhookUrl() was never called.'); | ||
| } | ||
| $successWebhookUrl = $this->successWebhookUrl; | ||
| if (!$successWebhookUrl) { |
| } | ||
| $successWebhookUrl = $this->successWebhookUrl; | ||
| if (!$successWebhookUrl) { | ||
| if (!$this->urlGenerator) { |
| @@ -30,9 +31,10 @@ public function __construct( | |||
| AssetBaseDirFormatter $asset, | |||
| WebhookConfigurationRegistryInterface $webhookConfigurationRegistry, | |||
| private readonly RequestStack $requestStack, | |||
| UrlGeneratorInterface|null $urlGenerator = null, | |||
There was a problem hiding this comment.
better to be consistent with parent construct. I suggest to switch with the request stack.
| @@ -27,9 +28,10 @@ public function __construct( | |||
| AssetBaseDirFormatter $asset, | |||
| WebhookConfigurationRegistryInterface $webhookConfigurationRegistry, | |||
| private readonly RequestStack $requestStack, | |||
| UrlGeneratorInterface|null $urlGenerator = null, | |||
There was a problem hiding this comment.
switch with request stack
|
|
||
| return new SuccessGotenbergEvent( | ||
| $id, | ||
| $request->getContent(true), |
There was a problem hiding this comment.
hmmmm. That would mean that we might need to save the file beforehand ?
| { | ||
| "status": 500, | ||
| "message": "An error occurred." | ||
| } |
Add Webhook component integration.
Webhook URLs fallback to the component's one (
/webhook/gotenberg) if no configuration is set.