[Hotfix] Fixed optional dependency to Stopwatch #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Beru
reviewed
Jul 25, 2024
Jean-Beru
reviewed
Jul 25, 2024
Jean-Beru
approved these changes
Jul 27, 2024
Neirda24
approved these changes
Sep 7, 2024
|
@maelanleborgne Can you rebase your PR to fix conflicts and merge it ? |
…o work without the stopwatch
maelanleborgne
force-pushed
the
hotfix/fix-optional-deps-on-stopwatch
branch
from
391fc3b to
694b8ab
Compare
✔️ done |
|
Thanks @maelanleborgne ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that #92 did not ship with the ability to work without the stopwatch component installed. This should fix it + re-introduce changes that allow a special display of the metrics when stopwatch isn't installed.