fix: accept strings in footer settings - #1135
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1083.
Passing strings to
FooterSettings(text=..., html=...), or assigning them through its documented setters, currently raisesAttributeErrorwhen the mail payload is serialized. The setters now wrap raw values inFooterTextandFooterHtml, following the other mail helpers. Existing wrapper objects and clearing a property withNoneremain supported.Updated the property documentation and mail example. Added five tests covering constructor and setter strings, empty strings, existing wrappers, and clearing values. Three of these tests reproduce the original failure.
Validation: all 114 unit tests pass. The repository's Ruff CI rules, changed-file pycodestyle/pyflakes, and Pylint error checks pass. The Docker-backed API integration suite was not run.