Skip to content

Fixed an issue where the position would break when selecting a member from the invite list. #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danney-chun
Copy link

@danney-chun danney-chun commented Jul 1, 2025

[fix]: Fixed an issue where the position would break when selecting a member from the invite list.

Problem ScreenShot

image
image

Fixes CLNP-7040

Changelogs

  • Fixed an issue where the position would break when selecting a member from the invite list

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit ad031a6
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6865b66d44cb5000080bef3a
😎 Deploy Preview https://deploy-preview-1349--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danney-chun danney-chun self-assigned this Jul 1, 2025
@danney-chun danney-chun requested a review from Copilot July 1, 2025 23:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes layout shifts in the invite list by changing scroll behavior and applying custom scrollbar styling.

  • Changed overflow-y from scroll to auto to only show the scrollbar when needed.
  • Added cross-browser scrollbar styling for better UX.
Comments suppressed due to low confidence (1)

@danney-chun danney-chun added this to the 3.16.11 milestone Jul 1, 2025
Copy link
Contributor

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요게 발생하는 이유가, 맥에서는 스크롤바 처리가 overlay 되어서 스크롤 할때만 나타나는데
시스템 설정에서 스크롤바를 아래처럼 항상 으로 변경하면 해당 문제가 발생하네요 (스크롤바가 공간을 차지하면서 문제 발생)
image

Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 자체는 .sendbird-user-list-item 클래스에 width 가, 432px 로 하드코딩 되어있어서 생기는 문제같습니다.
스크롤바가 생겨나면서 432px + 스크롤바 만큼 밀리는 현상이 있는 것 같아보여요!

요기 말고도 다른 유저 리스트 보여주는데서도 문제가 발생하고 있는 것 같습니다. (유저 밴, 오퍼레이터 등 유저 선택하는곳들)
아마도, 아래처럼 100% 로 조정하면 근본적으로 해결이 될 것 같슴다!

image

@danney-chun
Copy link
Author

요게 발생하는 이유가, 맥에서는 스크롤바 처리가 overlay 되어서 스크롤 할때만 나타나는데 시스템 설정에서 스크롤바를 아래처럼 항상 으로 변경하면 해당 문제가 발생하네요 (스크롤바가 공간을 차지하면서 문제 발생) image

오홋.. 맥에서 이런게 있었군요. ㅠ.ㅠ

Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants