Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add notes for notifee #216

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: add notes for notifee #216

merged 1 commit into from
Nov 7, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 6, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

Customer inquiry: https://sendbird.slack.com/archives/G016RFZKQ15/p1730856329012129

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Nov 6, 2024
@bang9 bang9 requested a review from OnestarLee November 6, 2024 01:46
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.57%. Comparing base (8474283) to head (adba004).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #216    +/-   ##
========================================
  Coverage   11.57%   11.57%            
========================================
  Files         356      356            
  Lines        8390     8390            
  Branches     2202     2324   +122     
========================================
  Hits          971      971            
+ Misses       7418     7343    -75     
- Partials        1       76    +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit b50d6ba Nov 7, 2024
7 checks passed
@bang9 bang9 deleted the chore/note-for-notifee branch November 7, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants