Skip to content

Wait for marketplace checks before merge - #5

Merged
sf-jin-ku merged 1 commit into
mainfrom
jin/wait-marketplace-checks
Apr 5, 2026
Merged

Wait for marketplace checks before merge#5
sf-jin-ku merged 1 commit into
mainfrom
jin/wait-marketplace-checks

Conversation

@sf-jin-ku

Copy link
Copy Markdown
Contributor

Summary

  • wait for marketplace PR checks to finish before trying the admin merge
  • keep the release sync flow fully automated for protected codex-plugins main

Testing

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-sync.yml"); puts "ok"'
  • git diff --check -- .github/workflows/release-sync.yml

@sf-jin-ku
sf-jin-ku merged commit d19a8ae into main Apr 5, 2026
3 checks passed
@sf-jin-ku
sf-jin-ku deleted the jin/wait-marketplace-checks branch April 5, 2026 14:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a1472bd15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +75 to +78
gh pr checks "${{ steps.sync_pr.outputs.pr_number }}" \
--repo "$MARKETPLACE_REPO" \
--watch \
--interval 10

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Handle empty-check race before watching PR checks

This step runs immediately after creating/updating the marketplace PR, but gh pr checks --watch does not wait for checks to be created if none exist yet; in gh it first fetches checks and returns an error (no checks reported on the '<branch>' branch) when the initial list is empty, so watch mode never starts. That creates an intermittent failure window right after PR creation when GitHub hasn’t registered check runs yet, causing the release-sync job to fail before gh pr merge can run.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant