fix: filter out global namespace from citation chips#1
Conversation
This commit explicitly filters out citations with the `global` namespace before rendering the `CitationChips` component. This suppresses the unintended "global 100%" badge that was rendering below assistant messages and causing visual clutter. Fixes tinyhumansai#1121. Co-authored-by: senamakel-droid <281415773+senamakel-droid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit explicitly filters out citations with the `global` namespace before rendering the `CitationChips` component. This suppresses the unintended "global 100%" badge that was rendering below assistant messages and causing visual clutter. Fixes tinyhumansai#1121. Co-authored-by: senamakel-droid <281415773+senamakel-droid@users.noreply.github.com>
This PR fixes issue tinyhumansai#1121 where assistant messages showed an unintended "global 100%" citation chip.
Changes
app/src/pages/conversations/components/CitationChips.tsxto explicitly filter out citations with theglobalnamespace before they are mapped and rendered.nullif the remaining filtered list of citations is empty, preventing a blank citation container.Testing
npm run testsuccessfully passes the full test suite inapp/.PR created automatically by Jules for task 11407212333738798334 started by @senamakel-droid
Note
Low Risk
Low risk UI-only change that filters a specific citation namespace before rendering; main risk is unintentionally hiding legitimate citations if upstream labeling changes.
Overview
Filters assistant message citations to exclude those with the
globalnamespace before rendering chips inCitationChips.Updates the empty-state logic to return
nullwhen all citations are filtered out, preventing an empty citation container from showing.Reviewed by Cursor Bugbot for commit c167b32. Bugbot is set up for automated code reviews on this repo. Configure here.