Skip to content

fix: filter out global namespace from citation chips#1

Open
senamakel-droid wants to merge 2 commits into
mainfrom
fix-global-citation-chip-11407212333738798334
Open

fix: filter out global namespace from citation chips#1
senamakel-droid wants to merge 2 commits into
mainfrom
fix-global-citation-chip-11407212333738798334

Conversation

@senamakel-droid

@senamakel-droid senamakel-droid commented May 3, 2026

Copy link
Copy Markdown
Owner

This PR fixes issue tinyhumansai#1121 where assistant messages showed an unintended "global 100%" citation chip.

Changes

  • Updated app/src/pages/conversations/components/CitationChips.tsx to explicitly filter out citations with the global namespace before they are mapped and rendered.
  • Re-evaluates whether to return null if the remaining filtered list of citations is empty, preventing a blank citation container.

Testing

  • Confirmed that npm run test successfully passes the full test suite in app/.

PR created automatically by Jules for task 11407212333738798334 started by @senamakel-droid


Note

Low Risk
Low risk UI-only change that filters a specific citation namespace before rendering; main risk is unintentionally hiding legitimate citations if upstream labeling changes.

Overview
Filters assistant message citations to exclude those with the global namespace before rendering chips in CitationChips.

Updates the empty-state logic to return null when all citations are filtered out, preventing an empty citation container from showing.

Reviewed by Cursor Bugbot for commit c167b32. Bugbot is set up for automated code reviews on this repo. Configure here.

This commit explicitly filters out citations with the `global` namespace
before rendering the `CitationChips` component. This suppresses the
unintended "global 100%" badge that was rendering below assistant
messages and causing visual clutter.

Fixes tinyhumansai#1121.

Co-authored-by: senamakel-droid <281415773+senamakel-droid@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

This commit explicitly filters out citations with the `global` namespace
before rendering the `CitationChips` component. This suppresses the
unintended "global 100%" badge that was rendering below assistant
messages and causing visual clutter.

Fixes tinyhumansai#1121.

Co-authored-by: senamakel-droid <281415773+senamakel-droid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant