Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Limit of Quantification (LOQ) for services and analyses #2682

Merged
merged 30 commits into from
Mar 11, 2025

Conversation

xispa
Copy link
Member

@xispa xispa commented Feb 26, 2025

Description of the issue/feature this PR addresses

This Pull Request makes possible to define the Limit of Quantification (LOQ)1 for services and analyses, so that:

  • Detected but < LLOQ is displayed when the result below the Lower Limit of Quantification (LLOQ), but above the Lower Limit of Detection (LLOD/LDL).
  • Not detected is displayed when the Lower Limit of Detection (LLOD) is below the Lower Limit of Quantification (LLOQ) and the result is lower than both.
  • < LLOD is displayed when the Lower Limit of Detection (LLOD) equals to the Limit of Quantification (LLOQ) and the result is lower than both.
  • The uncertainty is not displayed when the result is out of the quantifiable range
  • Additional wildcards for calculations: LOQ, LLOQ, ULOQ, BELOWLOQ, BELOWLLOQ, ABOVEULOQ
  • Added validators to ensure quantifiable range respects the detection threshold. This is, ensures the quantifiable range is always nested within the detection range, which is defined by the Lower Limit of Detection (LLOD) and Upper Limit of Detection (ULOD).

Current behavior before PR

Is not possible to define the Limit of Quantification (LOQ), but Lower and Upper Limits of Deteciton only.

Desired behavior after PR is merged

Is possible to define the Limit of Quantification (LOQ), along with Lower and Upper Limits of Deteciton only.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Footnotes

  1. Term "Quantification Limit" is used as well, with the acronym "QL". However, LOQ is the term standardized by international organizations such as IUPAC, ISO, and regulatory agencies like the FDA and EPA. LOQ is widely used in scientific literature, analytical chemistry and regulatory guidelines as well. Therefore, for formal scientific, technical, or regulatory contexts, LOQ is the better choice, as it aligns with standard usage and is more widely recognized.

@xispa xispa changed the title Added QuantificationLimit field for services and analyses Added Limit of Quantification (LOQ) for services and analyses Feb 28, 2025
@xispa xispa marked this pull request as ready for review March 2, 2025 14:48
@xispa xispa added Addition ➕ Cleanup 🧹 Code cleanup and refactoring labels Mar 2, 2025
@xispa xispa requested a review from ramonski March 2, 2025 14:52
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding this!

@ramonski ramonski merged commit e592c34 into 2.x Mar 11, 2025
2 checks passed
@ramonski ramonski deleted the quantification-limit branch March 11, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addition ➕ Cleanup 🧹 Code cleanup and refactoring
Development

Successfully merging this pull request may close these issues.

2 participants