Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method is not updated on instrument change in worksheet #2657

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 5, 2024

Description of the issue/feature this PR addresses

This Pull Request is an addition to #2647 . It ensures that methods from analyses are updated in accordance with the instrument and analysis when the instrument of the worksheet is changed.

Current behavior before PR

Methods from analyses are not updated on instrument change in worksheet

Desired behavior after PR is merged

Methods from analyses are updated on instrument change in worksheet

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa added the Bug 🐞 label Dec 5, 2024
@xispa xispa requested a review from ramonski December 5, 2024 14:32
@xispa xispa marked this pull request as ready for review December 5, 2024 14:33
@ramonski ramonski merged commit 426827a into 2.x Dec 6, 2024
2 checks passed
@ramonski ramonski deleted the fix-ws-instrument-method branch December 6, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants