-
Notifications
You must be signed in to change notification settings - Fork 68
feat(front): add members download button #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to export organization members as a CSV file. The changes introduce a download button on the people page that allows users to export member data (name, email, and GitHub login) in CSV format.
Key changes:
- Added a new
/people/exportendpoint that generates and downloads a CSV file containing organization members - Added a download button in the members list UI (shown only when viewing organization scope)
- Added basic test coverage for the export endpoint
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| front/lib/front_web/controllers/people_controller.ex | Implements organization_users action to fetch members and generate CSV export |
| front/lib/front_web/router.ex | Adds GET route /people/export for the new export functionality |
| front/lib/front_web/templates/people/members/members_list.html.eex | Adds download button in UI that links to the export endpoint |
| front/test/front_web/controllers/people_controller_test.exs | Adds test case verifying 404 response when user lacks organization access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
front/lib/front_web/templates/people/members/members_list.html.eex
Outdated
Show resolved
Hide resolved
17c6ac7 to
b7081a6
Compare
b7081a6 to
8c8c231
Compare
8c8c231 to
a380768
Compare
9ecd607 to
0b24f0d
Compare
- Add members download button on people page - Implement export members as csv endpoint - Add export members test
- Add service account list download button - Implement export endpoint at ServiceAccountController - Add org scope check on download button
0b24f0d to
d64568f
Compare
## π Description - Add members download button on people page - Implement export members as csv endpoint - Add export members test ## β Checklist - [x] I have tested this change - [ ] This change requires documentation update Signed-off-by: Veljko Maksimovic <[email protected]>
π Description
β Checklist