feat(secrethub): Add compact subject to OpenID JWT claims #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamir-suspect
requested review from
VeljkoMaksimovic and
lucaspin
as code owners
hamir-suspect
force-pushed
the
has/secrethub/oidc-short-sub
branch
2 times, most recently
from
7c98f15 to
edd7f9d
Compare
VeljkoMaksimovic
previously approved these changes
Sep 11, 2025
radwo
requested changes
Oct 16, 2025
dexyk
force-pushed
the
has/secrethub/oidc-short-sub
branch
from
4bb82d4 to
2937501
Compare
…and field truncation rules
…ild in Docker config
dexyk
force-pushed
the
has/secrethub/oidc-short-sub
branch
from
2937501 to
e9845be
Compare
dexyk
requested review from
DamjanBecirovic,
TomFern and
dexyk
as code owners
skipi
previously approved these changes
Oct 23, 2025
radwo
previously approved these changes
Oct 23, 2025
|
@hamir-suspect I added a few tweaks to AGENTS.md and DOCUMENTATION.md. Let me know what you think. Otherwise I think we are 👍 |
TomFern
approved these changes
Oct 23, 2025
skipi
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
sub127JWT claim and document its purpose.sub127from theorg/project/repo/ref-type/reftuple, sanitising each segment (removing:), shorteningbranch/tag/pull_requesttobr/tg/pr, trimming any leadingrefs/from the git ref, cappingorg/repo/refto 25/25/35 chars respectively, and enforcing an overall 127-character limit on the joined value.More details in this task.
✅ Checklist