Improve build#96
Conversation
| dnl The script previously overwrote CXXFLAGS with CFLAGS, but that's not always okay | ||
| dnl Save CFLAGS here, then clear it, and finally use it to append to both | ||
| save_CFLAGS="$CFLAGS" | ||
| CFLAGS="" | ||
|
|
There was a problem hiding this comment.
Just curious, is this also upstream or when we update smpeg will we need to re-add these changes on top again? (or do newer versions of smpeg just fix this for us already, aha)
| CXXFLAGS="$CXXFLAGS -std=c++03 $CFLAGS" | ||
| dnl Restore pre-save CFLAGS (see above comment on creation of save_CFLAGS) | ||
| CFLAGS="$save_CFLAGS $CFLAGS" |
There was a problem hiding this comment.
same question as above~
|
Nice, this is super cool! Honestly I can't really dig in and review this properly, but given the age of this code and all I'd be pretty happy to merge this in once we answer that smpeg question. Thanks very much for the work mate :D |
|
Ahh no that's not upstream I should probably look into trying to upstream it |
|
PR'd to upstream (or whatever the email equivalent of a PR is) |
|
Awesome, thanks very much mate! We'll see what they do but either way we'll have this PR to refer to. I'm happy to merge this whenever you think it's ready to go :D |
|
Yeah that's the first message in 6 years so I'm not sure if anyone's still there but we'll see (if no one's there, there won't be any smpeg updates to worry about so I guess it wouldn't matter) And it looks like I broke the static lib linux build with my disabling of pkg-config, let me find another solution to this... |
We don't include a webp lib, and otherwise it picks it up from homebrew and tries to link to it
eda7136 to
ec76b51
Compare
|
And that one broke my linux steam build |
ec76b51 to
4b9b380
Compare
-std=c++03 makes it unable to find sys/select.h for some reason
|
Okay seems to be working on Linux with and without steam, macOS, and Windows msys2 |
|
These changes LGTM, thanks @TellowKrinkle! I'll leave it to @DanielOaks to merge since he took a look already as well. |
|
Awesome, thanks again for the build improvements mate! :D |
./autogen.shto generate SDL2_image's configure file in build-std=C++03because it errors in C++11-mmacosx-version-min=10.5but the final binary wasn't, making it all pointlessmake MACOSX_DEPLOYMENT_TARGET=10.5-j8without it breaking