Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signals middleware #1220

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
+459 −384

add integration tests

90b27f6
Select commit
Loading
Failed to load commit list.
Draft

Add signals middleware #1220

add integration tests
90b27f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2025 in 0s

83.52% (-0.33%) compared to 3e8d9d2

View this Pull Request on Codecov

83.52% (-0.33%) compared to 3e8d9d2

Details

Codecov Report

Attention: Patch coverage is 66.12903% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (3e8d9d2) to head (90b27f6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e/network-signals-filter/network-signals-filter.ts 50.00% 8 Missing ⚠️
packages/signals/signals/src/core/emitter/index.ts 73.07% 7 Missing ⚠️
packages/signals/signals/src/lib/logger/index.ts 20.00% 4 Missing ⚠️
...ckages/signals/signals/src/core/signals/signals.ts 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   83.85%   83.52%   -0.33%     
==========================================
  Files         217      217              
  Lines        5798     5810      +12     
  Branches     1315     1324       +9     
==========================================
- Hits         4862     4853       -9     
- Misses        936      957      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov