Skip to content

fix(ButtonV2): button use && specificity as Link . PLAT-1438 - #1367

Merged
Douglasgomes027 merged 1 commit into
mainfrom
PLAT-1438-button-corners-look-inconsistent-when-button-v-2-is-used-as-a-link-fix
Mar 19, 2026
Merged

Douglasgomes027 merged 1 commit into
mainfrom
PLAT-1438-button-corners-look-inconsistent-when-button-v-2-is-used-as-a-link-fix

Conversation

@Douglasgomes027

@Douglasgomes027 Douglasgomes027 commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

The border-radius in ButtonRoot was set with !important to fix button corners
when ButtonV2 is used with as={Link}. This caused unintended side effects in
consumers that legitimately need to override border-radius (e.g. circular buttons),
forcing them to also use !important — creating a specificity arms race.

@Douglasgomes027
Douglasgomes027 requested a review from a team as a code owner March 19, 2026 12:07
@github-actions

Copy link
Copy Markdown

🚀 Snapshot Build Published

A snapshot version has been published to GitHub Packages for testing:

Snapshot Version: 2.41.3-snapshot-d948927a
Current Version: 2.41.3 (from registry/git tags)
Tag: pr-1367

You can install this version in your project using (with .npmrc configured for @securityscorecard:registry=https://npm.pkg.github.com and auth):

yarn add @securityscorecard/design-system@pr-1367

Published to GitHub Packages; snapshot versions are not unpublished when the PR is closed.

@Douglasgomes027
Douglasgomes027 force-pushed the PLAT-1438-button-corners-look-inconsistent-when-button-v-2-is-used-as-a-link-fix branch from 485d0b7 to 8dd9ec9 Compare March 19, 2026 12:16
@github-actions

Copy link
Copy Markdown

🚀 Snapshot Build Published

A snapshot version has been published to GitHub Packages for testing:

Snapshot Version: 2.41.3-snapshot-94d5b309
Current Version: 2.41.3 (from registry/git tags)
Tag: pr-1367

You can install this version in your project using (with .npmrc configured for @securityscorecard:registry=https://npm.pkg.github.com and auth):

yarn add @securityscorecard/design-system@pr-1367

Published to GitHub Packages; snapshot versions are not unpublished when the PR is closed.

@Douglasgomes027
Douglasgomes027 force-pushed the PLAT-1438-button-corners-look-inconsistent-when-button-v-2-is-used-as-a-link-fix branch from 8dd9ec9 to f167931 Compare March 19, 2026 12:32
@github-actions

Copy link
Copy Markdown

🚀 Snapshot Build Published

A snapshot version has been published to GitHub Packages for testing:

Snapshot Version: 2.41.3-snapshot-45dd6c06
Current Version: 2.41.3 (from registry/git tags)
Tag: pr-1367

You can install this version in your project using (with .npmrc configured for @securityscorecard:registry=https://npm.pkg.github.com and auth):

yarn add @securityscorecard/design-system@pr-1367

Published to GitHub Packages; snapshot versions are not unpublished when the PR is closed.

@Douglasgomes027
Douglasgomes027 merged commit 41d62a8 into main Mar 19, 2026
36 checks passed
@Douglasgomes027
Douglasgomes027 deleted the PLAT-1438-button-corners-look-inconsistent-when-button-v-2-is-used-as-a-link-fix branch March 19, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants