Skip to content

Conversation

@fabianbs96
Copy link
Member

No description provided.

@fabianbs96 fabianbs96 requested review from jusito and removed request for janniclas February 21, 2025 16:41
@fabianbs96 fabianbs96 marked this pull request as draft February 21, 2025 16:42
@fabianbs96 fabianbs96 added bug Something isn't working tooling labels Feb 21, 2025
@jusito jusito force-pushed the f-DockerInstallZ3 branch from b345ce6 to 96e73fd Compare March 3, 2025 10:38
Comment on lines 7 to 29
cmake_host_system_information(RESULT cores QUERY NUMBER_OF_LOGICAL_CORES)
set(additional_args -j ${cores})

# ignore flaky tests
if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
execute_process(COMMAND lsb_release -r
OUTPUT_VARIABLE UBUNTU_VERSION
OUTPUT_STRIP_TRAILING_WHITESPACE)
message("${UBUNTU_VERSION}")
string(REGEX REPLACE "^[^0-9]+([0-9]+)\\.([0-9]+).*" "\\1" UBUNTU_MAJOR_VERSION "${UBUNTU_VERSION}")

if ("${UBUNTU_MAJOR_VERSION}" GREATER 22)
# TODO tests shouldn't be flaky
list(APPEND additional_args -E "\"(LLVMBasedCFGTest|LLVMBasedICFGGlobCtorDtorTest|IDEInstInteractionAnalysisTest|IFDSUninitializedVariablesTest|IDEGeneralizedLCATest|IDEExtendedTaintAnalysisTest)\"")
# LLVMBasedCFGTest.HandlesCppStandardType
# IDEInstInteractionAnalysisTest.HandleBasicTest_04
# IFDSUninitializedVariablesTest.UninitTest_05_SHOULD_NOT_LEAK
# .UninitTest_06_SHOULD_NOT_LEAK
# IDEGeneralizedLCATest.StringTestCpp
# IDEExtendedTaintAnalysisTest.XTaint09
endif()
endif()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianbs96 As a workaround, I disabled flaky tests. Couldn't disable individual parts of it but at least we can use the CI with it. And amount of simultaneous tests is now taken from actual cores. Using ninja test or directly ctest is not affected by this.

@fabianbs96 fabianbs96 marked this pull request as ready for review March 3, 2025 18:17
@fabianbs96 fabianbs96 requested a review from MMory as a code owner March 3, 2025 18:17
@fabianbs96 fabianbs96 merged commit d12fadf into development Mar 3, 2025
6 checks passed
@fabianbs96 fabianbs96 deleted the f-DockerInstallZ3 branch March 3, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants