[pull] master from apache:master - #559
Merged
Merged
Conversation
* [Python] Add Watch transform with growth_of polling SDF
…ade (#39445) * Support serialization and deserialization for GoogleCloudStorageReadOptions Fixes an issue where GoogleCloudStorageReadOptions set on GcsOptions was annotated with @JsonIgnore, causing it to be omitted when serializing PipelineOptions for remote workers (e.g., Dataflow) and falling back to defaults. * Add a unit test * Override default fadvice to SEQUENTIAL This fixes the regression introduced by gcs-connector v3. * Spotless * Only support a subset of fields in GoogleCloudStorageReadOptions. * Refactor
…lients (#38768) * [Dataflow Streaming][Multikey] Support MultiKey commits in windmill clients - Add MultiKeyWorkItemCommitRequest to windmill.proto. - Support MultiKey commits in Commit model and StreamingEngineWorkCommitter. - Update GrpcCommitWorkStream to batch and stream MultiKey commit requests.
* Add equal_to_approx matcher for approximate numeric assertions equal_to only supports exact equality, so tests over floating point pipeline output had to supply a custom equals_fn. Add equal_to_approx, which compares real number elements (including numbers nested in tuples or lists) with math.isclose using configurable rel_tol and abs_tol, reusing the existing equal_to matching. Includes unit tests and a CHANGES.md entry. Fixes #18028 * Address review feedback: show int inputs and expand equal_to_approx docstring Apply reviewer suggestions on #39443: mix an int into the equal_to_approx tests to show integer inputs are accepted, and expand the equal_to_approx docstring with an Args section and an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )