[pull] master from apache:master - #547
Merged
Merged
Conversation
* Reuse Milvus client in vector sink write path _MilvusSink.write() constructed a new MilvusClient on every call, which discarded the retry-wrapped client created in __enter__. This bypassed the connection retry/backoff and left the initial client unclosed (leaked), while __exit__ only closed the last client. The write() docstring also incorrectly claimed the collection was flushed for durability. Reuse the client established in __enter__ for the upsert, and correct the docstring to describe the actual (no-flush) visibility semantics. Add a unit test asserting write() reuses the __enter__ client instead of reconstructing one per call. Co-authored-by: Cursor <cursoragent@cursor.com> * Clear Milvus client after close in sink __exit__ Set self._client to None after closing so a reused sink instance does not keep a stale closed client. Address review feedback. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )