[pull] master from apache:master - #513
Merged
Merged
Conversation
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.286.0 to 0.287.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.286.0...v0.287.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.287.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [BEAM] Fix Python VarIntCoder OverflowError on uint64 values The Cython write_var_int64/get_varint_size stream methods take a signed int64_t parameter. A Python int in the unsigned 64-bit range [2**63, 2**64) -- a uint64 -- is converted to that signed parameter at the call boundary and rejected with an OverflowError before the method body runs, even though the body already operates on the unsigned bit pattern and the VarInt wire encoding is well-defined. Fold such values to the signed int64 with the identical bit pattern (and thus identical VarInt encoding) before handing them to the stream. This matches Java's signed VarIntCoder on the wire; decoding remains signed. Values past 64 bits are left unchanged and still overflow downstream, preserving the coder's documented 64-bit limit. Adds test_varint_coder_uint64 covering no-overflow encoding, wire equivalence to the signed twin, size estimation, signed decode, and the still-raising out-of-range case (guarded on the compiled implementation). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Enforce 64-bit range in _as_signed_int64 for path parity Address review feedback: raise OverflowError in _as_signed_int64 for values outside the 64-bit range (reusing fits_in_64_bits) so the pure-Python path matches the Cython int64_t overflow instead of silently encoding out-of-range values. Both encode_to_stream and estimate_size already wrap OverflowError, so the user-facing message is unchanged. Drop the is_compiled guard in test_varint_coder_uint64 so the out-of-range case runs on both paths, add the negative lower-bound case (-(2**63) - 1), and remove the now-unused coder_impl import. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix uint64 overflow in VarIntCoderImpl.encode fast path The compiled encode() cast value to a C int64_t (ivalue, typed via coder_impl.pxd) for the small-ints fast path, which overflowed on uint64 values before reaching encode_to_stream's fold -- the cause of the test_varint_coder_uint64 CI failure on the Python PreCommit suites. Do the small-ints check with a plain Python-object comparison so it can't overflow; non-small values (including uint64 and out-of-range ints) fall through to StreamCoderImpl.encode -> encode_to_stream, where _as_signed_int64 folds them and raises the wrapped OverflowError for genuinely out-of-range values. Drop the now-unused ivalue int64_t local hint from coder_impl.pxd. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: damccorm <actions@main-runner-2404-9kmqn-xgm85.local>
* [Gemini] Add batching support to Java Remote Inference * Update sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix batching test issue --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…9004) * Add retry filter support to the Java Remote RetryHandler * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * spotless --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )