[pull] master from apache:master - #478
Merged
Merged
Conversation
* Fix WriteToPubSub to pass ordering_key to publish() method Fixes #36201 * Update pubsub_test.py * Update pubsub_test.py * Trigger CI rerun * Retry CI (flake) * Apply yapf formatting * Address review comments: use message_to_proto_str and skip ordering key test on Dataflow * Add Dataflow warning in WriteToPubSub.expand() for ordering key support * Update pubsub_integration_test.py * Update PR and modification in beam_PostCommit_Python.json Updated PR number and modification count. * Update pubsub_integration_test.py * Update pubsub_integration_test.py * Fix PubSub error * Update pubsub_integration_test.py * Fix formatting: remove trailing whitespace * Fix ordering key integration test: retry pull loop, fix indentation * Fix import order: google imports before apache_beam (isort) * Fix import ordering in pubsub_integration_test.py * Simplify publish kwargs, conditionally enable message ordering, add retry loop in integration test * Use with_attributes to initialize with_ordering and apply in PublisherClient setup * Fix PubSub tests: enable message ordering in PublisherClient to exercise full ordering flow * Rename to publish_with_ordering_key, gate Dataflow warning, fix test assertions --------- Co-authored-by: Nikita Grover <nikiatgrover10864@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )