[pull] master from apache:master - #198
Merged
Merged
Conversation
* remove groovy pubsublite dependencies * remove checkstyle suppressions * remove role config for pubsublite service and update role files
#37428) * Refactor: Unify batching args in ModelHandler constructors - Added 'max_batch_weight' and 'element_size_fn' to __init__ of all ModelHandlers (PyTorch, Sklearn, TF, ONNX, XGBoost, TensorRT, Hugging Face, vLLM, VertexAI). - Updated subclasses to delegate these args to 'super().__init__' or internal batching kwargs. - Removed 'with_element_size_fn' builder method from base class to enforce API consistency. - Updated tests to reflect the new API signature. * Address review comments: refactor tests and fix linting
…iguration (#37356) * [#37198] Make withBackOffSupplier public to enable bounded retry configuration Users need to configure bounded backoff to prevent infinite retry loops. Making withBackOffSupplier public allows users to set FluentBackoff.DEFAULT.withMaxRetries(n) and control retry behavior. Changes: - Changed withBackOffSupplier() visibility from package-private to public - Added comprehensive integration test with zero-delay BoundedBackOff - Test verifies: responses empty, 1 failure emitted, call count = maxRetries+1 The test uses a serializable BoundedBackOff class with assertions on both PAssert (pipeline outputs) and Metrics (retry counts) to ensure bounded retry behavior works correctly. Fixes #37198 Related to #37176 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Add explicit public modifier to withSleeperSupplier method Address review feedback from @damccorm to explicitly add the public keyword to withSleeperSupplier() for consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix Spotless formatting for withSleeperSupplier method Break long line to comply with code style requirements. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )