[pull] master from apache:master - #183
Merged
Merged
Conversation
This reverts commit 8da0802.
Undo #35962 and move from distutils to setuptools instead
* Make a copy of GcsUtil.java as GcsUtilLegacy.java * Change references from GcsUtil to GcsUtilLegacy in GcsUtilLegacy.java * Change public apis in GcsUtil.java to call the GcsUtilLegacy.java * Add mocking GcsUtilLegacy for tests and remove unnecessary references of gcsio in GcsUtil * Possible breaking change: removed unused public functions. * Get rid of the last bit (read option) gcsio references in GcsUtil.java. * Route the code path of open reading files to include api count metric. * Spotless check * Remove BatchInterface and RewriteOp from GcsUtil.java. Simplify some functions. * Rename GcsUtilLegacy to GcsUtilV1 * Make GcsUtilV1 package private * Import ExperimentalOptions * Move GcsReadOptionsFactory from GcsUtilV1 to GcsOptions * Fix a failed test * Add comments to SupressWarnings * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )