Mahmoud/eng 3111 integrate with stacks raw hex signing on extension by m-aboelenein · Pull Request #652 · secretkeylabs/xverse-web-extension

m-aboelenein · 2023-11-09T21:21:08Z

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

This PR introduces support for signing a transaction hex, which is parsed and displayed for the user for signing this enables stx multisig transactions

Issue Link: #ENG-3111

🔄 Changes

added flags to determine if the tx is multisig or not
disable advanced settings for confirm-stx-transaction screen if the tx already has signatures

related core pr: secretkeylabs/xverse-core#285

✅ Review checklist

Please ensure the following are true before merging:

Code Style is consistent with the project guidelines.
Code is readable and well-commented.
No unnecessary or debugging code has been added.
Security considerations have been taken into account.
The change has been manually tested and works as expected.
Breaking changes and their impacts have been considered and documented.
Code does not introduce new technical debt or issues.

…w-hex-signing-on-extension

…ntegrate-with-stacks-raw-hex-signing-on-extension

teebszet · 2023-11-24T07:52:05Z

nice work! 🙌

Conflicts: package-lock.json package.json src/app/screens/confirmFtTransaction/index.tsx src/app/screens/confirmStxTransaction/index.tsx src/app/screens/sendFt/index.tsx src/app/screens/signatureRequest/index.tsx src/app/screens/swap/useAlexSponsoredTransaction.ts src/app/screens/transactionRequest/helper.ts src/common/types/message-types.ts

teebszet · 2023-12-04T03:27:43Z

 };

-const SatsMethodsProvider: BitcoinProvider = {
+const SatsMethodsProvider: Partial<BitcoinProvider> = {


I'm curious what was the reasoning for Partial here? 😄

do we want to hide type errors when we forget to add a new method from sats-connect? 🤔

in my case, the version of sats-connect that we had in package.json was ahead of what was merged in develop at the time we might not want to keep it though, it's necessary now so the build doesn't fail

ah I see. I'd be keen to remove it before merge, since it was a good code hint before

@m-aboelenein did you have a chance to follow up on this one?

nice catch i reverted that change 👍

teebszet · 2023-12-04T05:24:18Z

+import { decodeToken } from 'jsontokens';
+import { useLocation } from 'react-router-dom';
+
+const useStxTransactionRequest = () => {


would be good to have a return type here. related to the core code review on txPayloadToRequest

There's an issue with strictly typing this hook since the types that are exposed from the @stacks/connect lib have errors with the types themselves so until that's resolved loosely typing here is our only solution.

I will open an issue on the @stacks/connect repo and add a follow-up issue.

…ntegrate-with-stacks-raw-hex-signing-on-extension

dhriaznov · 2023-12-22T09:01:59Z

    "@react-spring/web": "^9.6.1",
-    "@secretkeylabs/xverse-core": "6.0.1",
-    "@stacks/connect": "^6.10.2",
-    "@stacks/encryption": "4.3.5",


It looks like we currently still include @stacks/encryption in webpack/webpack.config.js, so I think it would make sense to remove it from there as well

DuskaT021 · 2023-12-25T13:25:20Z

Will be picked up for testing, after a comment gets resolved

) * fix: regenerate the unsignedTx with correct stxAddress after switch account * fix: minor cleanup * fix tx-request account switching * updated core version * added type checking and default values for feeMultipliers --------- Co-authored-by: Mahmoud Aboelenein <mahmoud@secretkeylabs.com>

github-actions · 2023-12-27T17:29:01Z

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7340521899

DuskaT021

Lgtm

…functionality-from-ext [ENG-5340] Export necessary functionality from the extension to core

m-aboelenein added 3 commits November 2, 2023 10:34

init tx hex handling

d3d7da9

Merge branch 'develop' into mahmoud/eng-3111-integrate-with-stacks-ra…

9a299ef

…w-hex-signing-on-extension

added stx hex tx signing support

3c4dbce

m-aboelenein requested a review from teebszet November 9, 2023 21:21

m-aboelenein self-assigned this Nov 9, 2023

teebszet reviewed Nov 13, 2023

View reviewed changes

Comment thread src/app/screens/transactionRequest/index.tsx Outdated

teebszet reviewed Nov 13, 2023

View reviewed changes

Comment thread src/app/screens/confirmStxTransaction/index.tsx

teebszet reviewed Nov 13, 2023

View reviewed changes

Comment thread src/app/screens/confirmStxTransaction/index.tsx Outdated

m-aboelenein and others added 6 commits November 15, 2023 17:22

Merge branch 'develop' into mahmoud/eng-3111-integrate-with-stacks-ra…

ce32d7b

…w-hex-signing-on-extension

integrate with connect core utils

257853a

fix stx tx serialization

c236db2

handle sign-hex for dapp interactions

7d7ec42

update core version

18051f4

add auh to tx-creation

308588b

teebszet reviewed Nov 22, 2023

View reviewed changes

Comment thread src/app/components/transactionsRequests/utils.ts Outdated

m-aboelenein added 2 commits November 22, 2023 18:35

Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-i…

2250045

…ntegrate-with-stacks-raw-hex-signing-on-extension

Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-i…

4fcd9f6

…ntegrate-with-stacks-raw-hex-signing-on-extension

teebszet reviewed Nov 24, 2023

View reviewed changes

Comment thread src/app/components/transactionsRequests/ContractCallRequest.tsx Outdated

teebszet reviewed Nov 24, 2023

View reviewed changes

Comment thread src/app/screens/sendNft/index.tsx Outdated

teebszet previously approved these changes Nov 24, 2023

View reviewed changes

teebszet reviewed Nov 24, 2023

View reviewed changes

Comment thread src/app/screens/transactionRequest/index.tsx

teebszet added the ready for test label Nov 26, 2023

m-aboelenein dismissed teebszet’s stale review via d596b0d November 30, 2023 15:17

m-aboelenein added 2 commits November 30, 2023 17:20

fix pending txs handling

156fd64

fix type issues

a5103b2

teebszet reviewed Dec 4, 2023

View reviewed changes

Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-i…

4171497

…ntegrate-with-stacks-raw-hex-signing-on-extension

update core version

fef354f

teebszet previously approved these changes Dec 5, 2023

View reviewed changes

teebszet added the Release 0.27.0 label Dec 12, 2023

Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-i…

0d0a5c4

…ntegrate-with-stacks-raw-hex-signing-on-extension

m-aboelenein dismissed teebszet’s stale review via 0d0a5c4 December 18, 2023 09:19

m-aboelenein added 3 commits December 18, 2023 11:51

revert removing signMultipleTransactions

d3d8657

update core version

38b5a92

Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-i…

06b05aa

…ntegrate-with-stacks-raw-hex-signing-on-extension

dhriaznov reviewed Dec 22, 2023

View reviewed changes

DuskaT021 added returned Tested by the QA, didn't pass checks and removed ready for test labels Dec 25, 2023

remove unused package aliases

5e33c8d

m-aboelenein requested a review from dhriaznov December 27, 2023 12:21

dhriaznov previously approved these changes Dec 27, 2023

View reviewed changes

dhriaznov added ready for test and removed returned Tested by the QA, didn't pass checks labels Dec 27, 2023

DuskaT021 added ready for release and removed ready for test labels Dec 27, 2023

m-aboelenein dismissed dhriaznov’s stale review via 45d9f63 December 27, 2023 17:25

DuskaT021 approved these changes Dec 27, 2023

View reviewed changes

m-aboelenein merged commit 65d33e3 into develop Dec 27, 2023

m-aboelenein deleted the mahmoud/eng-3111-integrate-with-stacks-raw-hex-signing-on-extension branch December 27, 2023 17:52

This was referenced Dec 29, 2023

release: v0.27.0 to main #731

Merged

release: v0.27.0 to develop #732

Merged

fedeerbes pushed a commit that referenced this pull request Oct 4, 2024

Merge pull request #652 from secretkeylabs/ENG-5340/export-necessary-…

829393b

…functionality-from-ext [ENG-5340] Export necessary functionality from the extension to core

Uh oh!

Conversation

m-aboelenein commented Nov 9, 2023 • edited by teebszet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔘 PR Type

📜 Background

🔄 Changes

✅ Review checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

teebszet commented Nov 24, 2023

Uh oh!

Uh oh!

teebszet Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m-aboelenein Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

teebszet Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

teebszet Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

m-aboelenein Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

teebszet Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

m-aboelenein Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

dhriaznov Dec 22, 2023

Choose a reason for hiding this comment

Uh oh!

DuskaT021 commented Dec 25, 2023

Uh oh!

github-actions Bot commented Dec 27, 2023

Uh oh!

DuskaT021 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

m-aboelenein commented Nov 9, 2023 •

edited by teebszet

Loading

teebszet Dec 4, 2023 •

edited

Loading