DLC flow updated to use blockstream API, added regtest #120
Draft
Polybius93 wants to merge 19 commits into
Draft
DLC flow updated to use blockstream API, added regtest #120Polybius93 wants to merge 19 commits into
Polybius93 wants to merge 19 commits into
Conversation
…her functions with the BlockCypher Testnet apiUrls
v10.0 + Build Changes
sosaucily
reviewed
Apr 26, 2023
| const { url, network } = options; | ||
| super({ | ||
| baseURL: url || network == 'Mainnet' ? BTC_BASE_URI_MAINNET : BTC_BASE_URI_TESTNET, | ||
| baseURL: url || network === 'Mainnet' |
There was a problem hiding this comment.
Here a sequence of ternaries seems a bit too confusing to read and understand. I would recommend just doing a switch, which will be more clear.
There was a problem hiding this comment.
I see you did that in wallet/index.ts too, so it's probably more consistent too.
Comment on lines
+25
to
+28
| bech32: 'bcrt', | ||
| pubKeyHash: 0x6f, | ||
| scriptHash: 0xc4, | ||
| wif: 0xef, |
There was a problem hiding this comment.
Since these are used twice, consider defining them in a const object
dhriaznov
pushed a commit
that referenced
this pull request
Jul 9, 2024
ENG-4564: Add PayPal to FeatureId type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.