feat: add wallet_sign and wallet_getEdDsaPublicKey RPC methods#121
Draft
aryzing wants to merge 3 commits into
Draft
feat: add wallet_sign and wallet_getEdDsaPublicKey RPC methods#121aryzing wants to merge 3 commits into
aryzing wants to merge 3 commits into
Conversation
- Add wallet_sign method with discriminated union on algorithm (EdDSA) - Add wallet_getEdDsaPublicKey method for retrieving Ed25519 public key - Define valibot schemas for request/response validation - Wire new methods into wallet namespace exports and type maps
- Rename edDsaSignParamsSchema -> ed25519SignParamsSchema with 'Ed25519' literal - Add ed25519phSignParamsSchema with 'Ed25519ph' literal - Update walletSignParamsSchema discriminated union to include both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekend AI project
This was part of a weekend project to practice having an AI agent implement a feature across several repos from a single Linear prompt. It worked, but I don't think anyone has time to review this feature. We can reopen if it valuable or ultimately close all related PRS.
Summary
Adds two new RPC method definitions to the wallet namespace for EdDSA signing capabilities.
New Methods
wallet_signalgorithmfield (currently supportsEdDSA)algorithm: 'EdDSA'— EdDSA signingpayload: string— Hex-encoded payload to sign{ signature: string, publicKey: string }— Both hex-encodedwallet_getEdDsaPublicKey{}{ publicKey: string }— Hex-encoded 32-byte Ed25519 public keyChanges
methods.tsWalletRequests,WalletSuccessResponses)