Merged
Conversation
Contributor
korgon
commented
Feb 12, 2026
- tracking clickthrough events originating from the shadows
… tracking clickthrough events
Contributor
There was a problem hiding this comment.
Pull request overview
Updates clickthrough detection to correctly handle events originating within Shadow DOM by using the event’s composed path, with accompanying test updates.
Changes:
- Switch link-detection traversal from
parentElementwalking toMouseEvent.composedPath()traversal (Shadow DOM aware). - Limit traversal depth using
CLICK_THROUGH_CLOSEST_MAX_LEVELSover the composed path. - Update and extend unit tests to mock
composedPath(), including Shadow DOM and fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/snap-controller/src/utils/isClickWithinProductLink.ts | Uses composedPath() to detect product-link clicks through Shadow DOM boundaries. |
| packages/snap-controller/src/utils/isClickWithinProductLink.test.ts | Adjusts tests to mock composedPath() and adds Shadow DOM + fallback coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/snap-controller/src/utils/isClickWithinProductLink.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dkonieczek
previously approved these changes
Feb 12, 2026
dkonieczek
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.