Skip to content

Comments

Bundle tooltip and checkbox improvements#1407

Open
chrisFrazier77 wants to merge 3 commits intodevelopfrom
bundle-improvements
Open

Bundle tooltip and checkbox improvements#1407
chrisFrazier77 wants to merge 3 commits intodevelopfrom
bundle-improvements

Conversation

@chrisFrazier77
Copy link
Contributor

adding new props to bundle to use new tooltip component

Copilot AI review requested due to automatic review settings November 26, 2025 20:26
@chrisFrazier77 chrisFrazier77 linked an issue Nov 26, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds tooltip and checkbox improvements to the RecommendationBundle component by introducing a new Tooltip component and enhancing checkbox click interaction. The changes enable configurable tooltips on bundle checkboxes and expand the clickable area around checkboxes for better UX.

Key changes:

  • New Tooltip component with portal support for better z-index handling
  • New props hideTooltip and checkboxClickPadding for RecommendationBundle
  • Enhanced checkbox wrapper with configurable padding and optional tooltips

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Tooltip.tsx New component implementation with portal and positioning support
Tooltip.test.tsx Comprehensive test coverage for the new Tooltip component
Tooltip.stories.tsx Storybook stories demonstrating Tooltip usage and positions
readme.md (Tooltip) Documentation for the new Tooltip component
index.ts (Tooltip) Export file for the Tooltip component
BundleSelector.tsx Integration of Tooltip and clickable wrapper for checkboxes
RecommendationBundle.tsx Props and CSS updates to support new features
RecommendationBundle.stories.tsx Story controls for new props
readme.md (Bundle) Documentation for new checkbox props
jest.config.js Added preact/compat mapping for portal support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ooltip.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave off tooltip for now - use case here doesn't seem to justify the changes.

We need to plan out how we want to make this change for the checkbox wrapper - seems we want to do it, but will need to modify integrations to make it happen due to breaking styling changes.

@chrisFrazier77 chrisFrazier77 requested a review from korgon December 2, 2025 21:39
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing further it has been decided to:

  • move changes to 1.0 fork
  • preservecheckboxClickPadding prop
  • have prop enabled by default
  • always render wrapper around checkbox (for padding to function)

@korgon
Copy link
Contributor

korgon commented Jan 16, 2026

@chrisFrazier77 can we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle recs checkbox improvements

2 participants