Bundle tooltip and checkbox improvements#1407
Bundle tooltip and checkbox improvements#1407chrisFrazier77 wants to merge 3 commits intodevelopfrom
Conversation
…dle to use new tooltip compon
There was a problem hiding this comment.
Pull request overview
This PR adds tooltip and checkbox improvements to the RecommendationBundle component by introducing a new Tooltip component and enhancing checkbox click interaction. The changes enable configurable tooltips on bundle checkboxes and expand the clickable area around checkboxes for better UX.
Key changes:
- New Tooltip component with portal support for better z-index handling
- New props
hideTooltipandcheckboxClickPaddingfor RecommendationBundle - Enhanced checkbox wrapper with configurable padding and optional tooltips
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Tooltip.tsx |
New component implementation with portal and positioning support |
Tooltip.test.tsx |
Comprehensive test coverage for the new Tooltip component |
Tooltip.stories.tsx |
Storybook stories demonstrating Tooltip usage and positions |
readme.md (Tooltip) |
Documentation for the new Tooltip component |
index.ts (Tooltip) |
Export file for the Tooltip component |
BundleSelector.tsx |
Integration of Tooltip and clickable wrapper for checkboxes |
RecommendationBundle.tsx |
Props and CSS updates to support new features |
RecommendationBundle.stories.tsx |
Story controls for new props |
readme.md (Bundle) |
Documentation for new checkbox props |
jest.config.js |
Added preact/compat mapping for portal support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/snap-preact-components/src/components/Atoms/Tooltip/Tooltip.tsx
Outdated
Show resolved
Hide resolved
packages/snap-preact-components/src/components/Atoms/Tooltip/Tooltip.tsx
Outdated
Show resolved
Hide resolved
packages/snap-preact-components/src/components/Atoms/Tooltip/Tooltip.tsx
Show resolved
Hide resolved
…ooltip.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
korgon
left a comment
There was a problem hiding this comment.
Let's leave off tooltip for now - use case here doesn't seem to justify the changes.
We need to plan out how we want to make this change for the checkbox wrapper - seems we want to do it, but will need to modify integrations to make it happen due to breaking styling changes.
...nap-preact-components/src/components/Organisms/RecommendationBundle/RecommendationBundle.tsx
Outdated
Show resolved
Hide resolved
...nap-preact-components/src/components/Organisms/RecommendationBundle/RecommendationBundle.tsx
Show resolved
Hide resolved
…nd updating checkboxclickpaddin
korgon
left a comment
There was a problem hiding this comment.
After discussing further it has been decided to:
- move changes to 1.0 fork
- preserve
checkboxClickPaddingprop - have prop enabled by default
- always render wrapper around checkbox (for padding to function)
|
@chrisFrazier77 can we close this PR? |
adding new props to bundle to use new tooltip component